Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize the error message for invalid 2fa codes #8071

Merged
merged 1 commit into from
Jul 20, 2018
Merged

Localize the error message for invalid 2fa codes #8071

merged 1 commit into from
Jul 20, 2018

Conversation

aforcier
Copy link
Contributor

Fixes #8070, using our own app error string for invalid 2fa codes instead of relying on the untranslated message from the server.

To test:

  1. Switch device to another language
  2. Log out and start logging into a WordPress.com account with 2fa enabled
  3. At the 2fa screen, enter an invalid verification code
  4. Confirm that the "Invalid verification code" error shown is localized

@aforcier aforcier added this to the 10.6 milestone Jul 20, 2018
@aforcier aforcier requested a review from khaykov July 20, 2018 16:51
khaykov
khaykov approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can confirm that error message is localized now :)

@khaykov khaykov merged commit 7150685 into develop Jul 20, 2018
@aforcier aforcier deleted the issue/8070-localize-2fa-error branch October 2, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaykov khaykov khaykov approved these changes

Assignees

@khaykov khaykov

Labels
i18n
Projects
None yet
Milestone
10.6
Development

Successfully merging this pull request may close these issues.
2 participants
@aforcier @khaykov